-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTL] Convert APB interfaces to AXI and add DMA #590
Open
calebofearth
wants to merge
65
commits into
main
Choose a base branch
from
cwhitehead-msft-gen2-axi-modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… incomplete EX access)
Ready & valid are 1-bit wide, do not access using bit select / range. Signed-off-by: Wiktoria Kuna <[email protected]>
When 'r_pri' is not set, read operation should be granted only if a read 'r_dv' is pending and there's no required write action 'w_dv'. Signed-off-by: Wiktoria Kuna <[email protected]>
…AT>0; compile fixes for sram
|
calebofearth
requested review from
bharatpillilli,
jlmahowa-amd and
nileshbpat
September 11, 2024 22:51
calebofearth
force-pushed
the
cwhitehead-msft-gen2-axi-modules
branch
from
September 11, 2024 23:29
cd21e77
to
25dfc56
Compare
bharatpillilli
previously approved these changes
Sep 12, 2024
calebofearth
force-pushed
the
cwhitehead-msft-gen2-axi-modules
branch
2 times, most recently
from
September 20, 2024 23:37
8818a71
to
fadb54e
Compare
calebofearth
force-pushed
the
cwhitehead-msft-gen2-axi-modules
branch
from
September 20, 2024 23:40
a08ffce
to
a9f300f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Still TODO
Task tracking
Resolves #563
Resolves #564